Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI for building and testing UMD #70

Merged
merged 35 commits into from
Sep 26, 2024
Merged

Add CI for building and testing UMD #70

merged 35 commits into from
Sep 26, 2024

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Sep 23, 2024 •
edited
Loading

Implements #45

Adding CI jobs guarding UMD. This PR covers a couple of stuff:

  • I did everything for both ubuntu 20 and 22
  • There will be a job for building docker images and publishing them as artefacts of tenstorrent organization on github. This flow was already used, and you can see dockers here: https://github.com/orgs/tenstorrent/packages?q=tt-mlir&tab=packages&q=tt-umd
  • I've created a "On PR" workflow, which will be mandatory check on checkins to main. It will make sure that umd_device lib can build
  • I've created a "On PR - Optional" workflow, which won't be mandatory for now. This will build tests and run them on wormhole machines. Grayskull machines still don't work at the moment, and blackhole are not available. I'd be hesitant to put this as mandatory since our machines might not be stable. Once github-ci team switches to pools of machines, this should be better, and I'd switch it to mandatory.
  • All of these workflows will be able to be ran manually, once they land in main, using "Actions" tab.
  • I've switched to clang 17, but since this is not tied to CI change, this is in separate PR Change compiler to clang #74. I've tested that the dockers provided were able to build using clang17 as well.
  • Fixed an issue (which shows on ubuntu22) with FILE where calling create-ethernet-map from our tests doesn't work due to file resolving to absolute path.

@broskoTT broskoTT mentioned this pull request Sep 24, 2024
Merged
@broskoTT broskoTT marked this pull request as ready for review September 25, 2024 10:35
@broskoTT broskoTT mentioned this pull request Sep 25, 2024
Merged
@broskoTT broskoTT linked an issue Sep 25, 2024 that may be closed by this pull request
Work on adding CI to umd repo #45
Closed
@broskoTT
first version of cis, probably don't work
1d791c6
@broskoTT
minor fix
d35d634
@broskoTT
docker image build
277c85e
@broskoTT
Fix build image
3ba9c9e
@broskoTT
fix build image v2
b960a10
@broskoTT
remove push
859356b
@broskoTT
revert push, workflow_dispatch works on main only
1b847ac
@broskoTT
fix build-tests, remove push for build-image
7550301
@broskoTT
fix docker image used, remove gitlab-ci, remove grayskull until it st…
3f29576 
…arts working
@broskoTT
tar directly what is needed without install
035092e
@broskoTT
modify jobs a bit
c39dd59
@broskoTT
try show all files
b7a304b
@broskoTT
working forward...
6190653
@broskoTT
fix artifacts. use self hosted machine with a specific card.
baee55a
@broskoTT
minor fix
2dcb027
@broskoTT
add forgotten needs. split build tests and run tests
dc52a4d
@broskoTT
maybe fix untar
6fbf85f
@broskoTT
cleanup tt-umd from last run
5c1b5ea
@broskoTT
some problem with dirs
76c965a
@broskoTT
tar non-absolute paths
38396c4
@broskoTT
minor fix
3393953
@broskoTT
fix untar v14563
32e00f9
vmilosevic
vmilosevic approved these changes Sep 25, 2024
View reviewed changes
pjanevskiTT
pjanevskiTT approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@pjanevskiTT pjanevskiTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left few nit comments

@broskoTT broskoTT added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit ad35764 Sep 26, 2024
10 of 12 checks passed
@broskoTT broskoTT deleted the brosko/ci-build branch September 26, 2024 07:05
broskoTT added a commit that referenced this pull request Sep 26, 2024
@broskoTT
Change compiler to clang (#74)
9b5f8cd 
Related to #45 
tt-metal uses clang compiler.
This configuration was copied from metal's CMakeLists.txt.
The irds that we're using for tt-metal already have this setup, so it
shouldn't disrupt anyone.
I've already installed clang-17 in #70, so CI will still work with this
switch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmilosevic vmilosevic vmilosevic approved these changes

@pjanevskiTT pjanevskiTT pjanevskiTT approved these changes

@joelsmithTT joelsmithTT Awaiting requested review from joelsmithTT

@vtangTT vtangTT Awaiting requested review from vtangTT

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Work on adding CI to umd repo
3 participants
@broskoTT @vmilosevic @pjanevskiTT