-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc build to py313 #2050
Conversation
was just talking to @john-science about the nbextensions. That's from back when we had an awesome dockerized jupyterhub instance of ARMI with all plugins. It added a few neat tools that some users liked. It's totally fine to remove it now since we don't know of anyone using them in jupyterhub at the moment. |
Okay, so I opened the docs your PR generates: https://github.com/terrapower/armi/actions/runs/13082534763?pr=2050 Almost everything is working, and looks great. But the "Gallery" section is broken: There are no links to the generated pages. I downloaded another PRs recently generated docs and they did not have this problem. @ntouran Could this be the dependency we dropped? |
Do we know what happened to the Gallery yet? Was that the dependency we removed? |
I haven't been researching this. I probably can't take a stab until next week given other priorities, though 😥 |
I can look into the gallery issue. I don't think it can be related to |
These fixes were all informed by the sphinx warnings during build. The labels weren't being applied correctly in the gallery and made it look bad. Looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I reviewed the output HTML and I think it looks good.
https://github.com/terrapower/armi/actions/runs/13185181566?pr=2050
What is the change?
The docs are being built with python 3.9. This updates them to python 3.13 (updating dependency pins in the process)
Why is the change being made?
Keepin' up with the times!
Checklist
doc
folder.pyproject.toml
.