Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the check for a jagged array during _writeParams #2051

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Update the check for a jagged array during _writeParams #2051

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
258338d
protect against the existential threat of single element numpy arrays
opotowsky Jan 11, 2025
8f7dac6
have this eval to jagged = true as opposed to prior fix, which was fi…
opotowsky Jan 11, 2025
0f9541f
release notes
opotowsky Jan 11, 2025
bcda603
make a static method and then add a unit test
opotowsky Jan 13, 2025
6ede045
Update doc/release/0.5.rst
opotowsky Jan 13, 2025
dd868b8
Minor thing
john-science Jan 14, 2025
0dd0f84
Merge branch 'main' of https://github.com/terrapower/armi into iwillw…
opotowsky Jan 14, 2025
79a0201
Merge branch 'iwillwriteanythingforparams-butiwontwritethat' of https…
opotowsky Jan 14, 2025
efaa5f5
Merge branch 'main' of https://github.com/terrapower/armi into iwillw…
opotowsky Jan 17, 2025
2fbbc3f
Merge branch 'main' of https://github.com/terrapower/armi into iwillw…
opotowsky Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion armi/bookkeeping/db/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,8 @@ def _getShape(arr: [np.ndarray, List, Tuple]):
elif isinstance(arr, (list, tuple)):
return (len(arr),)
else:
return (1,)
# not a list, tuple, or array (likely int, float, or None)
return 1

c = comps[0]
groupName = c.__class__.__name__
Expand Down
1 change: 1 addition & 0 deletions doc/release/0.5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ API Changes

Bug Fixes
---------
#. Fix database class bug in check for jagged arrays. (`PR#XXXX <https://github.com/terrapower/armi/pull/XXXX>`_)
opotowsky marked this conversation as resolved.
Show resolved Hide resolved
#. TBD

Quality Work
Expand Down