New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing commit msg checkbox from PR template #2078

Open

john-science wants to merge 1 commit into main from pr_form

Member

john-science commented Feb 7, 2025

What is the change?

Removed one checkbox from the PR template:

The commit message(s) follow good practices.

Why is the change being made?

We have a squash-and-merge policy for ARMI PRs. So I don't care if you have some silly PR messages in the history of your feature branch.

Checklist

This PR has only one purpose or idea.
Tests have been added/updated to verify any new/changed code.

The code style follows good practices.
The commit message(s) follow good practices.

The release notes have been updated if necessary.
The documentation is still up-to-date in the doc folder.
The dependencies are still up-to-date in pyproject.toml.


          Removing commit msg checkbox from PR template

fb322ba

john-science added the cleanup label

john-science requested a review from opotowsky

February 7, 2025 19:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup