Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Daily CI #25

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Fix Daily CI #25

merged 4 commits into from
Feb 13, 2025

Conversation

Mayank77maruti
Copy link
Contributor

@Mayank77maruti Mayank77maruti commented Feb 6, 2025 •
edited
Loading

@Mayank77maruti Mayank77maruti mentioned this pull request Feb 6, 2025
Closed
@Mayank77maruti
Copy link
Contributor Author

@alixander PTAL
Thanks

@Mayank77maruti
Copy link
Contributor Author

@alixander friendly ping.
Thank you

alixander
alixander requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run ./ci/make.sh fmt?

@Mayank77maruti
Copy link
Contributor Author

@alixander please take a look.
Thanks
i have looked into the tests.
Screenshot From 2025-02-13 14-19-33
I tested it on the local fork and the tests passed

alixander
alixander approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alixander alixander merged commit 243d866 into terrastruct:master Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix ci daily
2 participants
@Mayank77maruti @alixander