Change filename to -alpine / upgrade Ubuntu #2756
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this has been triggered though. # Failed test 'Check whether CSV output matches baseline file from testssl.sh' # at t/61_diff_testsslsh.t line 57. # # %s # @@ -1,5 +1,4 @@ # "id","fqdn/ip","port","severity","finding","cve","cwe" # -"engine_problem","/","443","WARN","No engine or GOST support via engine with your ./bin/openssl.Linux.x86_64","","" # "service","testssl.sh/81.169.166.184","443","INFO","HTTP","","" # "pre_128cipher","testssl.sh/81.169.166.184","443","INFO","No 128 cipher limit bug","","" # "SSLv2","testssl.sh/81.169.166.184","443","OK","not offered","","" # Looks like you failed 1 test of 1. t/61_diff_testsslsh.t ..............
polarathene
reviewed
May 6, 2025
| @@ -52,7 +52,7 @@ jobs: | |||
| with: | |||
| push: ${{ github.event_name != 'pull_request' }} | |||
| context: . | |||
| file: Dockerfile.git | |||
| file: Dockerfile-alpine | |||
There was a problem hiding this comment.
FWIW, a common convention I see in projects generally is a . followed by the variant name. The official convention suggested by Docker is the opposite to use .Dockerfile as the file extension.
I think Dockerfile. as a prefix instead of as a suffix is preferred for co-location when viewing a file list sorted by filename. It may also be recognized by editors like VSCode, I'm not sure if that's the case with - as a delimiter.
Regardless it doesn't differ in usage, so whatever is comfortable 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
see subject. + #2752
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()