Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning #118

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix deprecation warning #118

merged 1 commit into from
Aug 20, 2024

Conversation

sbennett33
Copy link
Contributor

Fixes deprecation warning:

using map.field notation (without parentheses) to invoke function LevelWeb.AdminPanel.User.__live_admin_config__() is deprecated, you must add parentheses instead: remote.function()
  (live_admin 0.12.0) lib/live_admin.ex:126: LiveAdmin.fetch_config/3
  (live_admin 0.12.0) lib/live_admin/components/nav.ex:41: anonymous fn/3 in LiveAdmin.Components.Nav.render/1
  (elixir 1.17.2) lib/enum.ex:2531: Enum."-reduce/3-lists^foldl/2-0-"/3
  (live_admin 0.12.0) lib/live_admin/components/nav.ex:38: LiveAdmin.Components.Nav.render/1
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/renderer.ex:79: Phoenix.LiveView.Renderer.to_rendered/2
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/diff.ex:335: Phoenix.LiveView.Diff.component_to_rendered/3
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/diff.ex:753: Phoenix.LiveView.Diff.render_component/8
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/diff.ex:697: Phoenix.LiveView.Diff.zip_components/5
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/diff.ex:680: anonymous fn/4 in Phoenix.LiveView.Diff.render_pending_components/6
  (stdlib 6.0.1) maps.erl:860: :maps.fold_1/4
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/diff.ex:625: Phoenix.LiveView.Diff.render_pending_components/6
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/diff.ex:143: Phoenix.LiveView.Diff.render/3
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/static.ex:249: Phoenix.LiveView.Static.to_rendered_content_tag/4
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/static.ex:132: Phoenix.LiveView.Static.render/3
  (phoenix_live_view 0.20.17) lib/phoenix_live_view/controller.ex:39: Phoenix.LiveView.Controller.live_render/3
  (phoenix 1.7.14) lib/phoenix/router.ex:484: Phoenix.Router.__call__/5
  (level 0.1.0) lib/level_web/endpoint.ex:1: LevelWeb.Endpoint.plug_builder_call/2

Fixes deprecation warning when calling __live_admin_config__ without the parentheses
@tfwright tfwright merged commit ca18c3a into tfwright:main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants