Refactor main.js to include validateRequest middleware #6
Conversation
| @@ -6,13 +6,15 @@ import setupSwagger from './helper/swagger/swagger.config.js'; | |||
| import gptMiddleware from './middleware/ai/gpt.middleware.js'; | |||
| import asyncHandler from './middleware/error/asyncHandler.middlware.js'; | |||
There was a problem hiding this comment.
There is a typo in the import path for asyncHandler. It should be asyncHandler.middleware.js instead of asyncHandler.middlware.js.
| @@ -6,13 +6,15 @@ | |||
| import gptMiddleware from './middleware/ai/gpt.middleware.js'; | |||
| import asyncHandler from './middleware/error/asyncHandler.middlware.js'; | |||
| import errorHandler from './middleware/error/errorHandler.middlware.js'; | |||
There was a problem hiding this comment.
There is a typo in the import path for errorHandler. It should be errorHandler.middleware.js instead of errorHandler.middlware.js.
|
|
||
| const start = async () => { | ||
| await startMongoose(); | ||
|
|
||
| const app = express(); | ||
|
|
||
| app.use(express.json()); | ||
| app.use(asyncHandler(validateRequest)) |
There was a problem hiding this comment.
Using asyncHandler with validateRequest is a good approach, but ensure that validateRequest is indeed an asynchronous function. If it's not, you may not need to wrap it with asyncHandler, which could lead to unnecessary complexity.
| @@ -0,0 +1,21 @@ | |||
| import aiService from '../../service/ai/ai.service.js'; | |||
|
|
|||
| const context = 'You are an AI that acts as a middleware for API request validation. You will receive the body, header, query, method, and URL of a request. Your task is to analyze whether all fields in the request adhere to established patterns and are present. If any field is invalid or missing, return an error message in JSON format: { message, statusCode, status }. If it is a creation (POST) or update (PUT) request, you must also check if the schema for that operation exists and is valid using the get_schemas function. If the request is valid and all fields are correct, return a success message in JSON format: { message: "OK", statusCode: "200", status: "OK" }. Important, don’t send ```JSON in the response.'; | |||
There was a problem hiding this comment.
The context string is excessively long and could be simplified or broken down into smaller, more manageable parts. Consider summarizing the key points to improve readability.
|
|
||
| const { message, statusCode, status } = JSON.parse(response.content); | ||
| console.log({ message, statusCode, status }); | ||
| if (statusCode != 200) { |
There was a problem hiding this comment.
Using != for comparison can lead to unexpected results due to type coercion. It is recommended to use !== for strict comparison.
| next() | ||
| } | ||
|
|
||
| export default validateRequest |
There was a problem hiding this comment.
There is no newline at the end of the file. It is a good practice to end files with a newline to avoid issues in version control.
No description provided.