DON-1121: Add age confirmation checkbox #1891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type was FormGroup<any>, now it's inferred as:
FormGroup<{
donationAmount: FormControl<string | null>;
billingPostcode: FormControl<string | null>;
optInCharityEmail: FormControl<boolean | null>;
optInTbgEmail: FormControl<boolean | null>;
giftAid: FormControl<boolean | null>;
homeOutsideUK: FormControl<string | null>;
homeAddress: FormControl<string | null>;
homePostcode: FormControl<string | null>;
unmatched: FormControl<boolean | null>
}>
bdsl
force-pushed
the
DON-1121-regular-giving-adult-checkbox
branch
from
595f244 to
7c8f88c
Compare
…tep changes Previously for me validation was only running when I step-changed with the continue button, not when I clicked a step heading.
bdsl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the copy is exactly right - the "Please tick the box to confirm" message makes sense for adults who didn't notice the form but maybe isn't right for children who didn't tick the box. Doesn't make sense to ask them to wait years and come back though.