confine pulpcore cli checks for setups where the cli is available #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
pulpcore-cli-available
branch
from
cf26f56 to
293688a
Compare
evgeni
commented
Aug 26, 2024
| feature.any_instance.stubs(:cli_available?).returns(false) | ||
| end | ||
| result = run_check(subject) | ||
| assert result.success?, 'Check expected to succeed' |
There was a problem hiding this comment.
interestingly, checks that do not pass confinement are still reported as success, not skipped 🤷♀️
|
Verified by |
evgeni
commented
Aug 26, 2024
| @@ -15,6 +16,10 @@ class Features::Pulpcore < ForemanMaintain::Feature | |||
| end | |||
| end | |||
|
|
|||
| def cli_available? | |||
There was a problem hiding this comment.
I guess, design wise, this should be moved to an own feature, but I didn't want to refactor all of this in a bugfix PR.
ekohl
approved these changes
Aug 26, 2024
|
Successfully tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.