Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop rotate-script from executables-section in gemspec #930

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Drop rotate-script from executables-section in gemspec #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions foreman_maintain.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ the Foreman/Satellite up and running."
s.files += `git ls-files extras`.split("\n")
s.extra_rdoc_files = ['LICENSE', 'README.md']
s.require_paths = ['lib']
s.executables = ['foreman-maintain',
'foreman-maintain-complete', 'foreman-maintain-rotate-tar']
Copy link
Member

@ehelms ehelms Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just drop the whole script at this point? foreman-maintain-rotate-tar that is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it from s.executables ensures that the gem-installer does not create a ruby-wrapper script in /usr/bin/foreman-maintain-rotate-tar.

I am not fully sure, why tar needs to use the shell-script when changing volume.
Also it is only set, if the tar-command does not use --gzip.
The history says we need it for the extract to work smoothly: 2beadc6

s.executables = ['foreman-maintain', 'foreman-maintain-complete']
s.required_ruby_version = ">= 2.7", "< 4"

s.add_dependency 'clamp'
Expand Down
Loading