Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow foreman_remote_execution 15.x #212

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 30, 2025

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Jan 30, 2025

Capybara::ElementNotFound: Unable to find css "#select2-foreman_salt_salt_variable_salt_module_id-container"
    test/integration_test_helper.rb:165:in `select2'
    foreman_salt/test/integration/salt_variable_test.rb:21:in `block in <class:SaltVariableTest>'

@evgeni
Copy link
Member Author

evgeni commented Jan 30, 2025

I don't exactly understand why I had to change things to select, but I am rather sure it's related to theforeman/foreman@871a647 🙈

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as far as the rex dependency goes, can't really speak to select x select2

@sbernhard
Copy link
Contributor

can you please rebase again @evgeni. then the failure should be gone.

@evgeni
Copy link
Member Author

evgeni commented Jan 30, 2025

🍏

@sbernhard sbernhard merged commit a67f508 into theforeman:master Jan 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants