Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixtures.pulpproject.org for bats tests #1784

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Mar 6, 2024

The fixtures at fedorapeople.org cannot be accessed when running RHEL 9 in FIPS mode. This also has the nice affect of using the fixtures Pulp maintains rather than a variety of artifacts from multiple places that are not owned by a group.

@ekohl
Copy link
Member

ekohl commented Mar 6, 2024

@parthaa @ianballou mind taking a look?

@ehelms I noticed our webserver also doesn't support TLS 1.3 (because it's EL7) so do we not test syncing client repos or is Ruby/Python code ignoring FIPS?

@ehelms
Copy link
Member Author

ehelms commented Mar 6, 2024

@ehelms I noticed our webserver also doesn't support TLS 1.3 (because it's EL7) so do we not test syncing client repos or is Ruby/Python code ignoring FIPS?

To my knowledge they ignore it, which is somewhat by design as we are not guaranteeing the application layer be FIPS compliant.

@ianballou
Copy link
Contributor

ianballou commented Mar 21, 2024

@ehelms if you've tested this change against BATS I'm cool acking it.

@ehelms
Copy link
Member Author

ehelms commented Mar 26, 2024

@ehelms if you've tested this change against BATS I'm cool acking it.

I ran it locally, give me the green check mark and we'll see what our pipelines think.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me.

@ekohl ekohl merged commit 4c2e830 into theforeman:master Mar 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants