Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start rhsmcertd after sub-man registers in BATS #1899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianballou
Copy link
Contributor

subscription-manager is no longer sending package profiles without rhsmcertd as of 1.29.45.

By default, the service is dead until the system is rebooted. This should theoretically fix the current failing errata tests.

Also, I deleted the katello-agent tests since it's very gone by now.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like something we should fix in registration itself.

@evgeni
Copy link
Member

evgeni commented Feb 27, 2025

This feels wrong. I was reading the sub-man diff as "will send profile itself if rhsmcertd is not running", is that part not working?

@@ -17,7 +17,6 @@ bats_tests:
- "fb-test-foreman.bats"
- "fb-katello-content.bats"
- "fb-katello-container.bats"
- "fb-katello-client-katello-agent.bats"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep that for now -- Satellite 6.14 is still supported ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't realize we reused the same BATS for such old Foremans.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :)

@ekohl
Copy link
Member

ekohl commented Feb 27, 2025

By default, the service is dead until the system is rebooted. This should theoretically fix the current failing errata tests.

If it's about rhsmcertd then candlepin/subscription-manager@a8acd2d looks like a relevant change.

Is there anything in the journal for rhsmcertd?

@evgeni
Copy link
Member

evgeni commented Feb 27, 2025

It is relevant, yes, we're talking to sub-man developers about this right now :)

@ianballou
Copy link
Contributor Author

Question is -- should we merge this because it likely doesn't hurt anything and will likely get the pipeline running again until we have our fix?

@ianballou ianballou force-pushed the rhsmcertd-live-bats branch 2 times, most recently from 86818d1 to 8d26e5a Compare February 27, 2025 17:27
@ianballou
Copy link
Contributor Author

The gist of the issue is that sub-man is no longer sending the package profile when rhsmcertd is dead, but it should be.

@evgeni
Copy link
Member

evgeni commented Feb 27, 2025

Yeah, I am cool merging this while we wait for the subman fix

@ekohl
Copy link
Member

ekohl commented Feb 27, 2025

I have a general rule to at least refer to an issue in a comment to track why we have workarounds and make it clear it is a workaround.

@ianballou
Copy link
Contributor Author

I couldn't find an issue so I just used subscription-manager 1.29.46 as the point of removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants