-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python < 3.8 and replace pkg_resources with importlib #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would kill Python 2 compatibility, no?
Version 3.3.1 still had Python 2.7 support: https://pypi.org/project/importlib-resources/3.3.1/ |
let's find out by fixing CI on 2.7: #38 |
3a810e3
to
c87d44d
Compare
Thanks! Looks good then. One oddity I still can offer. https://github.com/theforeman/jenkins-jobs/blob/master/theforeman.org/pipelines/lib/obal.groovy does not ( |
setup.py
Outdated
'importlib_resources; python_version < "3.7"', | ||
'importlib_metadata; python_version < "3.8"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given on EL8 we use py3.11 now, this is safe to merge once we turn of the el7 builders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we then refactor this in a "drop Python < 3.8 compatibility" PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think downstream it's still py3.6 (with whatever ansible is compatible with that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to care about this or can we assume Python 3.8+ by now?
c87d44d
to
9b23b91
Compare
9b23b91
to
71160af
Compare
71160af
to
f2f8933
Compare
f2f8933
to
c13603d
Compare
No description provided.