Fix not found error handling

thegazelle-ad · Jan 23, 2024 · cb8d602 · cb8d602 · vercel · Jan 23, 2024
1 parent daa29b8
commit cb8d602
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 19 deletions.
diff --git a/app/error.tsx b/app/error.tsx
diff --git a/app/issue/[issueNumber]/[articleSlug]/not-found.tsx b/app/issue/[issueNumber]/[articleSlug]/not-found.tsx
@@ -0,0 +1,9 @@
+import Link from 'next/link'
+
+export default function NotFound() {
+  return (
+    <div className="flex justify-center w-full">
+        <h2>Article not found!</h2>
+    </div>
+  )
+}
diff --git a/db/queries/articles.ts b/db/queries/articles.ts
@@ -36,6 +36,7 @@ import {
     wrapCache,
 } from "../common";
 import { format } from 'date-fns';
+import { notFound } from 'next/navigation';
 
 export const UNCATEGORIZED_CATEGORY: Category = { id: UNCATEGORIZED_CATEGORY_ID, name: UNCATEGORIZED_CATEGORY_NAME, slug: UNCATEGORIZED_CATEGORY_SLUG };
 
@@ -182,14 +183,15 @@ export const getArticle = async(slug: string): Promise<ArticlePage> => {
         .limit(1);
 
     if (!Array.isArray(article) || article.length === 0)
-        throw new Error('Article not found!');
+        notFound();
 
     if (!article[0].markdown)
-        throw new Error('Article missing content!');    
+        notFound();
 
     // Don't render unpublished articles
     if (article[0].publishedAt == null)
-        throw new Error('Article not found!');
+        notFound();
+        // throw new Error('Article not found!');
 
     // attempt to get audio
     const audioUri = await db.select({