UI improvements for Android #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thermitex
reviewed
Aug 2, 2024
pubspec.yaml
Outdated
| @@ -44,7 +44,7 @@ dependencies: | |||
| flutter_animate: ^4.5.0 | |||
| flutter_colorpicker: ^1.1.0 | |||
| live_activities: ^1.9.3 | |||
| home_widget: ^0.5.0 | |||
| home_widget: ^0.6.0 | |||
There was a problem hiding this comment.
Let's keep this at 0.5.0 for now, as upgrading flutter to >=3.20 will cause problems in persistent_bottom_nav_bar. Will upgrade them in next versions
lib/src/routes/root.dart
Outdated
| @@ -243,6 +244,13 @@ class RootState extends State<Root> with WidgetsBindingObserver { | |||
|
|
|||
| @override | |||
| Widget build(BuildContext context) { | |||
| // Change the icon color according to the current theme. | |||
| final isDarkTheme = Theme.of(context).brightness == Brightness.dark; | |||
There was a problem hiding this comment.
Can use context.isDarkMode as shortcut
|
Thanks a lot for the contribution!! |
thermitex
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the background of the status bar:
Before
After
Remove the background of the gestures indicator:
Before
After