-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations Part: Filter annotation types. #24
Merged
cplutte
merged 17 commits into
thesaurus-linguae-aegyptiae:working_master
from
JKatzwinkel:annotations_filter_by_type
Feb 17, 2016
Merged
Annotations Part: Filter annotation types. #24
cplutte
merged 17 commits into
thesaurus-linguae-aegyptiae:working_master
from
JKatzwinkel:annotations_filter_by_type
Feb 17, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With HandledMenuItems for toggle annotation type filtering.
Move retrieval of annotation types/subtypes configuration objects to controller methods so that annotations part won't have direct access to service layer.
Conflicts: org.bbaw.bts.ui.corpus/src/org/bbaw/bts/ui/corpus/parts/AnnotationsPart.java
cplutte
added a commit
that referenced
this pull request
Feb 17, 2016
Annotations Part: Filter annotation types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that a release should be made soon, lets take care of the details (#23) later.
These changes bring a View Menu in Annotations Part which allows for selection of which types of related objects should be displayed. As requested, rubra don't get displayed by default. Annotations can be filtered by their type or subtype.
The whole thing looks like this:
Also, comment editor now shows the comment's ID, which can be very useful in case you want to know the comment ID: