repo: Ensure keyids are correct in signing event #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signing tool already does this but makes sense to verify in signing-event (since metadata can be modified outside the signing tools).
There is a private embedded in the code for e2e tests to use. This key has an "incorrect" keyid (hash does not match)
The test key keyid changed: this means all expected results also change. The only real change is the keyid, but this means the ordering of keys changes so it looks like a larger change.
jku
force-pushed
the
check-keyids-in-signing-event
branch
from
beb88f2 to
f8f9b5a
Compare
jku
force-pushed
the
check-keyids-in-signing-event
branch
from
ba255ee to
2dceec4
Compare
|
I've added a release prep commit (with changelog and version number changes), with the assumption we want to do a release. |
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyids should match the hash of the key content. The signing tool already does this but makes sense to verify in signing-event (since metadata can be modified outside the signing tools).
Upstream python-tuf does not enforce keyids since I/ we think that
This is all true but because other clients (awslabs/tough) disagree, this now becomes an interop issue
See sigstore/root-signing#1431