Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove volume directives from dockerfile #61

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

reubenmiller
Copy link
Contributor

Removing the volume declarations gives more control to the user who they want to mount volumes, and it avoid anonymous volumes from being created

Removing the volume declarations gives more control to the user who they want to mount volumes, and it avoid anonymous volumes from being created
Copy link

github-actions bot commented Jan 9, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
19 0 1 19 100 8m42.497343s

Passed Tests

Name ⏱️ Duration Suite
Ignore Containers Marked With A Specific Label 31.797 s Container
Grace period to allow container to startup 5.028 s Operations
Service is up 0.200 s Operations
Get Logfile Request 4.709 s Operations
Get Configuration File 5.049 s Operations
Execute Shell Command 2.551 s Operations
Install application using docker compose 16.100 s Operations
Get Container Logs 4.769 s Operations
Get Container Logs without explicit container name 4.707 s Operations
Get Container Logs For Non-existent container 2.542 s Operations
Update From Legacy Versions 145.025 s Self-Update-Compat
Trigger self update via local command 26.189 s Self-Update
Self update should only update if there is a new image 24.203 s Self-Update
Self update using software update operation 110.115 s Self-Update
Rollback when trying to install a non-tedge based image 24.946 s Self-Update
Self update using software update operation using Container type 111.215 s Self-Update
Cloud Connection is Online 0.212 s Telemetry
Service status 0.380 s Telemetry
Sends measurements 2.731 s Telemetry

@reubenmiller reubenmiller added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 7ec072c Jan 9, 2025
8 checks passed
@reubenmiller reubenmiller deleted the feat-remove-anon-volumes branch January 9, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant