Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't copy network settings when forking a container #127

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

reubenmiller
Copy link
Collaborator

Due to some unknown issues in podman 4.4, when a container fork is created and the host config is copied, this causes the podman network iptables rules to be removed when the forked container exits.

By ignoring the copying of the container host config, then the iptables rules seem to be preserved. Anyway, the forked container does not need to have a network to perform its task.

Due to some unknown issues in podman 4.4, when a container fork is created and the host config is copied, this causes the podman network iptables rules to be removed when the forked container exits.

By ignoring the copying of the container host config, then the iptables rules seem to be preserved. Anyway, the forked container does not need to have a network to perform its task.
@reubenmiller reubenmiller changed the title fix: don't copy host settings when forking a container fix: don't copy network settings when forking a container Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
32 0 0 32 100 7m31.49408s

Passed Tests

Name ⏱️ Duration Suite
Get Container Logs 3.149 s Container-Logs
Get Container Logs with only last N lines 0.519 s Container-Logs
Remove Container 7.560 s Container-Remove
Remove Container Non Existent Container Should Not Through An Error 0.061 s Container-Remove
Restart Container 0.469 s Container-Restart
Restart Unknown Container Fails 0.066 s Container-Restart
Update to tedge-container-plugin-ng 26.114 s Installation
Check for Update 8.044 s Operations-Clone
Clone Existing Container 27.779 s Operations-Clone
Clone Existing Container by Timeout Whilst Waiting For Exit 18.125 s Operations-Clone
Clone Existing Container but Waiting For Exit 23.940 s Operations-Clone
Ignore Containers With Given Label 21.079 s Operations-Clone
Install/uninstall container package from private repository - credentials file 14.425 s Operations-Private-Registries
Install/uninstall container package from private repository - credentials script 14.944 s Operations-Private-Registries
Install/uninstall container package from private repository - credentials script with cache 21.821 s Operations-Private-Registries
Install/uninstall container package from private repository - engine credentials 19.162 s Operations-Private-Registries
Install/uninstall container package from private repository - docker from docker 38.646 s Operations-Private-Registries
Get Configuration 5.309 s Operations
Install/uninstall container-group package 17.203 s Operations
Install invalid container-group 2.991 s Operations
Install container-group with multiple files - app1 16.515 s Operations
Install container-group with multiple files - app2 10.048 s Operations
Install/uninstall container package 14.887 s Operations
Install/uninstall container package from file 10.283 s Operations
Manual container creation/deletion 20.216 s Operations
Manual container creation/deletion with error on run 7.876 s Operations
Manual container created and then killed 10.434 s Operations
Self Update Is Present Using Self Type 0.147 s Self
Self Update Is Present Using Container Type 0.147 s Self
Self Update Is Not Present 0.148 s Self
Service status 18.859 s Telemetry-Main
Sends measurements 70.528 s Telemetry-Main

@reubenmiller reubenmiller added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit b7f70a2 Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant