Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptor_rejects_untrusted_client_certificates following hyper upgrade #3375

Open
jarhodes314 opened this issue Feb 3, 2025 · 0 comments
Assignees
Labels
refactoring Developer value

Comments

@jarhodes314
Copy link
Contributor

In #3371, I ignored acceptor_rejects_untrusted_client_certificates since I wasn't getting the desired error message, but I believe the underlying functionality is still behaving as expected. The point of checking the error is correct is intended to ensure the process failed in the correct way. If we didn't do this, the client could, for example, fail to trust the server certificates and the connection would be immediately rejected rather than failing on a client certificate error. The type of error we get is also important as when working, it makes it easy for clients to diagnose the issue on their side rather than just getting some generic TLS failure which is near impossible to debug. The issue may well be caused by some refactoring on reqwest's side, as I had to change some error handling there.

@jarhodes314 jarhodes314 added the refactoring Developer value label Feb 3, 2025
@jarhodes314 jarhodes314 self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Developer value
Projects
None yet
Development

No branches or pull requests

1 participant