test: re-enable client certificate test #3382
Merged
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove the
#[ignore]
attribute on one of the client certificate tests. Due to a change in the underlying certificate verifier, the error rustls produces is slightly different to what it was previously, and this was causing the test to fail. We aren't interested in the specifics of the error message produced, we simply care that the error arose from the client certificate verification and not some bug in the test code. Having updated the test to check for the updated error, I've verified that it still fails for otherwise failing connections (e.g. the client not trusting the server certificate). Therefore I think a simple update to the test to reflect the new behaviour is sufficient here.Types of changes
Paste Link to the issue
acceptor_rejects_untrusted_client_certificates
following hyper upgrade #3375Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments