Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS Snapshot Tests. #401

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Fix iOS Snapshot Tests. #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
976dbab
Update device and update snapshot images.
thomaskioko Jan 19, 2025
5c0f30e
Update test device and update snapshot images.
thomaskioko Jan 19, 2025
3f9c595
Update device name. 😵‍💫
thomaskioko Jan 19, 2025
53395f8
Update configuration.
thomaskioko Jan 19, 2025
3e37fd3
Use different device and update snapshot images.
thomaskioko Jan 19, 2025
cc8ba41
Update macos image for snapshot tests.
thomaskioko Jan 19, 2025
f8b0885
Use iPhone 16 pro and update snapshot images.
thomaskioko Jan 19, 2025
ecff026
Update mac image to match snapshot test job
thomaskioko Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ jobs:
path: ./**/build/reports/tests/

build-ios:
runs-on: macos-14
runs-on: macos-15
timeout-minutes: 60
env:
FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT: 60
Expand Down Expand Up @@ -339,7 +339,7 @@ jobs:
fastlane/logs

ios-snapshot-test:
runs-on: macos-14
runs-on: macos-15
timeout-minutes: 60
env:
FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT: 60
Expand Down
15 changes: 11 additions & 4 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
default_platform(:ios)

# Set timeout for xcodebuild commands
TEST_DEVICE = "iPhone 16 Pro (18.0)"
TEST_DEVICE = "iPhone 16 Pro"

platform :ios do

Expand All @@ -24,7 +24,7 @@ platform :ios do
device: TEST_DEVICE,
clean: true,
result_bundle: true,
xcargs: "-retry-tests-on-failure",
xcargs: "-retry-tests-on-failure -skipPackagePluginValidation",
number_of_retries: 2,
fail_build: true,
derived_data_path: "derived_data"
Expand All @@ -37,7 +37,7 @@ platform :ios do
device: TEST_DEVICE,
clean: true,
result_bundle: true,
xcargs: "-retry-tests-on-failure",
xcargs: "-retry-tests-on-failure -skipPackagePluginValidation",
number_of_retries: 2,
fail_build: true,
derived_data_path: "derived_data"
Expand Down Expand Up @@ -65,7 +65,14 @@ platform :ios do
clean: true,
skip_package_ipa: true,
skip_archive: true,
skip_codesigning: true
skip_codesigning: true,
export_method: "development",
export_options: {
method: "development",
signingStyle: "automatic",
compileBitcode: false,
provisioningProfiles: {}
}
)
end

Expand Down
4 changes: 2 additions & 2 deletions ios/Modules/SwiftUIComponents/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-snapshot-testing",
"state" : {
"revision" : "42a086182681cf661f5c47c9b7dc3931de18c6d7",
"version" : "1.17.6"
"revision" : "2e6a85b73fc14e27d7542165ae73b1a10516ca9a",
"version" : "1.17.7"
}
},
{
Expand Down
Loading