refactor: make Serializer return a normal Vec<u8>

channels-serdes/src/bincode.rs

@@ -2,7 +2,7 @@ use alloc::vec::Vec;
 
 use bincode::Options;
 
-use crate::{Deserializer, PayloadBuffer, Serializer};
+use crate::{Deserializer, Serializer};
 
 fn default_bincode_config() -> impl Options {
 	bincode::options()
@@ -43,20 +43,8 @@ where
 {
 	type Error = bincode::Error;
 
-	fn serialize(
-		&mut self,
-
-		t: &T,
-	) -> Result<PayloadBuffer, Self::Error> {
-		let mut buf = PayloadBuffer::new();
-		let bincode = &mut default_bincode_config();
-
-		let size_hint = bincode.serialized_size(t)?;
-		if let Ok(size_hint) = usize::try_from(size_hint) {
-			buf.reserve(size_hint);
-		}
-
-		bincode.serialize_into(&mut buf, t).map(|_| buf)
+	fn serialize(&mut self, t: &T) -> Result<Vec<u8>, Self::Error> {
+		default_bincode_config().serialize(t)
 	}
 }
 

channels-serdes/src/cbor.rs

@@ -1,6 +1,6 @@
 use alloc::vec::Vec;
 
-use crate::{Deserializer, PayloadBuffer, Serializer};
+use crate::{Deserializer, Serializer};
 
 /// The [`mod@ciborium`] serializer which automatically works with all
 /// types that implement [`serde::Serialize`] and [`serde::Deserialize`].
@@ -20,13 +20,10 @@ where
 {
 	type Error = ciborium::ser::Error<std::io::Error>;
 
-	fn serialize(
-		&mut self,
-		t: &T,
-	) -> Result<PayloadBuffer, Self::Error> {
-		let mut buf = PayloadBuffer::new();
-
-		ciborium::into_writer(t, &mut buf).map(|_| buf)
+	fn serialize(&mut self, t: &T) -> Result<Vec<u8>, Self::Error> {
+		let mut buf = Vec::new();
+		ciborium::into_writer(t, &mut buf)?;
+		Ok(buf)
 	}
 }
 

channels-serdes/src/json.rs

@@ -1,6 +1,6 @@
 use alloc::vec::Vec;
 
-use crate::{Deserializer, PayloadBuffer, Serializer};
+use crate::{Deserializer, Serializer};
 
 /// The [`mod@serde_json`] serializer which automatically works with all
 /// types that implement [`serde::Serialize`] and [`serde::Deserialize`].
@@ -25,16 +25,8 @@ where
 {
 	type Error = serde_json::Error;
 
-	fn serialize(
-		&mut self,
-		t: &T,
-	) -> Result<PayloadBuffer, Self::Error> {
-		let mut buf = PayloadBuffer::new();
-
-		let data = serde_json::to_vec(t)?;
-		buf.put_slice(&data);
-
-		Ok(buf)
+	fn serialize(&mut self, t: &T) -> Result<Vec<u8>, Self::Error> {
+		serde_json::to_vec(t)
 	}
 }
 

channels-serdes/src/lib.rs

@@ -28,10 +28,6 @@ extern crate alloc;
 
 use alloc::vec::Vec;
 
-mod buf;
-
-pub use self::buf::PayloadBuffer;
-
 /// The [`Serializer`] trait allows converting a type `T` to safe-to-transport
 /// byte sequences.
 ///
@@ -41,10 +37,7 @@ pub trait Serializer<T> {
 	type Error;
 
 	/// Serialize `t` to a buffer.
-	fn serialize(
-		&mut self,
-		t: &T,
-	) -> Result<PayloadBuffer, Self::Error>;
+	fn serialize(&mut self, t: &T) -> Result<Vec<u8>, Self::Error>;
 }
 
 /// The [`Deserializer`] trait allows converting a byte slice to a type `T`.