Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activating multiple keys #3747

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

samaradel
Copy link
Contributor

Description

  • Activate Active column
  • Support multiple keys
  • Remove selected class from unselected keys

Changes

image

Screencast.from.01-12-24.19.16.27.webm

Related Issues

Tested Scenarios

  • Create multiple SSH keys
  • Activate/deactivate any of them
  • Select / multi-select keys before deploying any solution

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3696

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Jan 26, 2025

error when deploying micro vm with two active ssh keys is gone, good job

however, chips and active status in ssh table are not synced
I activated a key from the deployment page
image
went to ssh keys page and key status was not active
image
is this how it is supposed to behave?

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this related to the pr or to the flist but in algorand and casperlaps I noted that the authorized keys always duplicated.
image

@0oM4R
Copy link
Contributor

0oM4R commented Feb 4, 2025

Created Caprover cluster with 2 ssh keys and wasn't able to ssh with one of the added keys

image

@0oM4R
Copy link
Contributor

0oM4R commented Feb 4, 2025

tested against:

  • full vm

  • micro vm

  • algorand ⚠️ duplicated keys

  • caprover 🟥 falied

  • k8s [master- worker]

  • casperlaps ⚠️ duplicated keys

  • Nostr 🟥 can't access with more than one key

  • Gitea

  • TFRobot 🟥 can't access with more than one key

  • Jenkins ⚠️ duplicate kyes

  • Peertube

  • Funkwhale 🟥 can't access at all; connection refused.

  • Mattermost

  • Discourse ⚠️ duplicated kyes

  • Taiga ⚠️ duplicated kyes

  • Static Website

  • Nextcloud ⚠️ duplicated kyes

  • Presearch ⚠️ duplicated kyes

  • Subsquid ⚠️ duplicated kyes

  • Casperlabs ⚠️ duplicated kyes

  • Node Pilot

  • Umbrel

  • Wordpress 🟥 can't access with more than one key

  • Jitsi

@samaradel samaradel marked this pull request as draft February 16, 2025 09:17
@samaradel
Copy link
Contributor Author

verified and blocked on https://github.com/threefoldtech/tf_operations/issues/3142

@samaradel
Copy link
Contributor Author

samaradel commented Feb 25, 2025

  • Verified images:
    • Algorand
    • Casperlabs
    • Nostr
    • TFRobot
    • Jenkins
    • Taiga
  • Images with updated Flists
    • Discourse
    • Funkwhale (connection refused)
    • Nextcloud
    • Presearch
    • Subsquid
    • Wordpress

@samaradel
Copy link
Contributor Author

@amiraabouhadid the keys synced please try again.
Screencast from 25-02-25 18:33:54.webm
@0oM4R @maayarosama did you face the same issue? please provide screenshots.

@samaradel samaradel marked this pull request as ready for review February 25, 2025 16:42
@samaradel samaradel requested a review from 0oM4R February 25, 2025 16:42
@samaradel samaradel marked this pull request as draft February 26, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants