add mutex for a safe accessing on memory between goroutines: (#2196)

pkg/diagnostics/diagnostics.go

@@ -75,23 +75,30 @@ func (m *DiagnosticsManager) GetSystemDiagnostics(ctx context.Context) (Diagnost
 	}
 
 	var wg sync.WaitGroup
-	for _, module := range Modules {
+	var mut sync.Mutex
+	var hasError bool
 
+	for _, module := range Modules {
 		wg.Add(1)
 		go func(module string) {
 			defer wg.Done()
 			report := m.getModuleStatus(ctx, module)
+
+			mut.Lock()
+			defer mut.Unlock()
+
 			results.ZosModules[module] = report
 
 			if report.Err != nil {
-				results.SystemStatusOk = false
+				hasError = true
 			}
 		}(module)
 
 	}
 
 	wg.Wait()
 
+	results.SystemStatusOk = !hasError
 	results.Online = m.isOnline(ctx)
 
 	return results, nil

pkg/perf/networkhealth/networkhealth.go

@@ -54,11 +54,16 @@ func (t *NetworkHealthTask) Run(ctx context.Context) (interface{}, error) {
 	reports := []ServiceStatus{}
 
 	var wg sync.WaitGroup
+	var mut sync.Mutex
 	for _, serviceUrl := range servicesUrl {
 		wg.Add(1)
 		go func(serviceUrl string) {
 			defer wg.Done()
 			report := getNetworkReport(ctx, serviceUrl)
+
+			mut.Lock()
+			defer mut.Unlock()
+
 			reports = append(reports, report)
 		}(serviceUrl)
 	}