Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Include minimum 6 month lockup in commitment date calculation #706

Closed
wants to merge 3 commits into from
Closed

[Backport] Include minimum 6 month lockup in commitment date calculation #706

wants to merge 3 commits into from

Conversation

theref
Copy link
Member

@theref theref commented Dec 19, 2023 •
edited by michalsmiarowski
Loading

Backport of 0a26de3

michalsmiarowski and others added 2 commits December 19, 2023 16:09
@michalsmiarowski
Update @ledgerhq/connect-kit-loader dependency
4cc87bd 
Updated the `@ledgerhq/connect-kit-loade` dependency to `1.1.8` so that it is
tethered to version 1.1.8 of the connect-kit.
@lukasz-zimnoch
Merge pull request #705 from threshold-network/update-ledger-connect-…
43e81fe 
…kit-dependency

Update @ledgerhq/connect-kit-loader dependency
derekpierre
derekpierre previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 - one suggestion.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/delay/index.html.

arjunhassard
arjunhassard approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@arjunhassard arjunhassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, would have been very confusing!!

cygnusv
cygnusv previously approved these changes Dec 19, 2023
View reviewed changes
@theref theref dismissed stale reviews from cygnusv and derekpierre via 83d276d December 19, 2023 17:06
derekpierre
derekpierre previously approved these changes Dec 19, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/delay/index.html.

@theref theref changed the base branch from main to releases/mainnet/v1.14.0 December 19, 2023 17:26
@theref theref added this to the v1.14.1 milestone Dec 19, 2023
@theref theref mentioned this pull request Dec 19, 2023
Merged
@derekpierre derekpierre dismissed their stale review December 19, 2023 19:54

Unclear about the need to backport to 1.14.0...?

@theref
Copy link
Member Author

theref commented Dec 20, 2023

This backport isn't required, the change is on v1.14.1

@theref theref closed this Dec 20, 2023
@michalsmiarowski
Copy link
Contributor

michalsmiarowski commented Dec 22, 2023 •
edited
Loading

Just adding a note here that this backport isn't required because we've created a separate branch for v1.14.1, where this change is already applied (see Backport of 0a26de3).

@michalsmiarowski michalsmiarowski changed the title Include minimum 6 month lockup in commitment date calculation [Backport] Include minimum 6 month lockup in commitment date calculation Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunhassard arjunhassard arjunhassard approved these changes

@cygnusv cygnusv cygnusv left review comments

@derekpierre derekpierre derekpierre left review comments

@michalsmiarowski michalsmiarowski Awaiting requested review from michalsmiarowski

@lukasz-zimnoch lukasz-zimnoch Awaiting requested review from lukasz-zimnoch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14.1
Development

Successfully merging this pull request may close these issues.
6 participants
@theref @michalsmiarowski @arjunhassard @cygnusv @derekpierre @lukasz-zimnoch