feat: implement policy merge in dataflow dynamics #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log_dir does not exist within this context
…assert_can_deploy_all_together method
…rent selection matches
feat: can_deploy_all method in profile assertions
chore: avoid re-resolving a query in dynamic port bindings if the current selection matches
Ftpd base methods expect data_dir to be a string
re-add find_all_dataset_folders function and rewrite dataset folders in the root folder transfer test to match the pattern
Use init_policy from the port as a default for the policy Do not override the existing init flag in the policy `policy.fetch(:init, port.model.init_policy)` to set the init value if not already provided in the policy
…ation feat: early deploy at network generation
eduardacoppo
force-pushed
the
policy_merge_in_dataflow_dynamics
branch
from
340f306 to
3a91448
Compare
- Correctly merges policy, making sure :init is only set if it wasn't already defined. This prevents :init from being overwritten when explicitly provided. - Adds a test to confirm that an existing :init value remains unchanged.
Fixes incorrect .and_return(...) usage in tests, replacing it with .with(...) to properly validate method arguments.
eduardacoppo
force-pushed
the
init_policy_defaults_to_true
branch
from
1b547b7 to
f28f627
Compare
fix: transfer server and transfer client
chore: warn in case it could not find unmanaged task
…o_true feat: add flag to set init policy to true
eduardacoppo
changed the base branch from
init_policy_defaults_to_true
to
transition-to-runkit
Previously, if a parameter was added to the designer-provided policy, no automated policy determination would be performed. That meant that the init flag would not be computed in this case. To fix this, a merge_policy function was implemented to merge the explicit policy (the designer-provided one) and the computed policy (init, for instance) The fix follows these rules: - if a value is in policy, use it; - otherwise use the value from computed_policy Also, if the type policy is set to data, the size policy must be removed, as its only meaningful for the type buffer and it causes the connection to fail. The Ruby method `merge` merges two hashes. According to the documentation: "Returns a new hash containing the contents of other_hash and the contents of hsh. If no block is specified, the value for entries with duplicate keys will be that of other_hash." In this case, to follow the rules of prioritizing the value from explicit_policy in case of key duplication, 'other_hash' is explicit_policy and 'hsh' is computed_policy
eduardacoppo
force-pushed
the
policy_merge_in_dataflow_dynamics
branch
from
3a91448 to
7489a90
Compare
|
Created a PR for it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for
[sc-68813]
On-top of rock-core#462
How I did it
Results, How I tested
Checklist