-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: expose callback function #9032
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
7e8ed9d
to
99cf51e
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #9032 +/- ##
==========================================
- Coverage 76.26% 76.21% -0.06%
==========================================
Files 466 467 +1
Lines 70750 71101 +351
==========================================
+ Hits 53961 54188 +227
- Misses 13425 13526 +101
- Partials 3364 3387 +23
Flags with carried forward coverage won't be shown. Click here to find out more. |
What problem does this PR solve?
Issue Number: ref #8690
What is changed and how does it work?
mockPDServiceDiscovery
needs it.Check List
Tests
Release note