Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add IsEnabled for circuit breaker #9049

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 8, 2025

What problem does this PR solve?

Issue Number: ref #8678

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Feb 8, 2025
@rleungx
Copy link
Member Author

rleungx commented Feb 10, 2025

/retest

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (c92da83) to head (3ef3ee5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9049      +/-   ##
==========================================
- Coverage   76.23%   76.15%   -0.09%     
==========================================
  Files         467      468       +1     
  Lines       71155    71419     +264     
==========================================
+ Hits        54247    54388     +141     
- Misses      13515    13614      +99     
- Partials     3393     3417      +24     
Flag Coverage Δ
unittests 76.15% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from lhy1024 and okJiang February 10, 2025 02:47
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 10, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-10 06:45:57.820514633 +0000 UTC m=+252600.216736687: ☑️ agreed by okJiang.
  • 2025-02-11 03:06:55.509694092 +0000 UTC m=+325857.905916149: ☑️ agreed by lhy1024.

@rleungx
Copy link
Member Author

rleungx commented Feb 11, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit db1c2b1 into tikv:master Feb 11, 2025
25 checks passed
@rleungx rleungx deleted the disable-cb branch February 11, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants