Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: skip if circuit breaker is disabled #9078

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 13, 2025

What problem does this PR solve?

Issue Number: ref #8678.

What is changed and how does it work?

After this PR, if we disable the circuit breaker, the metrics won't be recorded.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2025
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Feb 13, 2025

/cc @Tema

Copy link
Contributor

ti-chi-bot bot commented Feb 13, 2025

@rleungx: GitHub didn't allow me to request PR reviews from the following users: Tema.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Tema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rleungx
Copy link
Member Author

rleungx commented Feb 13, 2025

/retest

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Feb 13, 2025

/retest

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (30e8ed7) to head (edb46bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9078      +/-   ##
==========================================
+ Coverage   76.15%   76.19%   +0.04%     
==========================================
  Files         468      468              
  Lines       71435    71435              
==========================================
+ Hits        54404    54433      +29     
+ Misses      13617    13590      -27     
+ Partials     3414     3412       -2     
Flag Coverage Δ
unittests 76.19% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Member Author

rleungx commented Feb 13, 2025

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 13, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 13, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 13, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-13 08:04:18.223429562 +0000 UTC m=+516500.619651624: ☑️ agreed by bufferflies.
  • 2025-02-13 08:26:01.202653981 +0000 UTC m=+517803.598876044: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit e893032 into tikv:master Feb 13, 2025
25 checks passed
@rleungx rleungx deleted the disable-cb1 branch February 13, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants