-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: skip if circuit breaker is disabled #9078
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/cc @Tema |
@rleungx: GitHub didn't allow me to request PR reviews from the following users: Tema. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
1 similar comment
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9078 +/- ##
==========================================
+ Coverage 76.15% 76.19% +0.04%
==========================================
Files 468 468
Lines 71435 71435
==========================================
+ Hits 54404 54433 +29
+ Misses 13617 13590 -27
+ Partials 3414 3412 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #8678.
What is changed and how does it work?
After this PR, if we disable the circuit breaker, the metrics won't be recorded.
Check List
Tests
Release note