-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor workflows into a proper go library (#14)
* Add option mechanism * Make task runner logger configurable * TaskRunner config * Lint issues * Observability library improvements * Unix socket support * Add options to NewJobService function * Fix runner tests * Update readme
- Loading branch information
1 parent
74c2299
commit c443055
Showing
8 changed files
with
323 additions
and
123 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| package workflows | ||
|
|
||
| import ( | ||
| "context" | ||
| "net" | ||
| "net/http" | ||
| "strings" | ||
|
|
||
| "connectrpc.com/connect" | ||
| "github.com/tilebox/tilebox-go/grpc" | ||
| "github.com/tilebox/tilebox-go/protogen/go/workflows/v1/workflowsv1connect" | ||
| ) | ||
|
|
||
| // clientConfig contains the configuration for a gRPC client to a workflows service. | ||
| type clientConfig struct { | ||
| httpClient connect.HTTPClient | ||
| url string | ||
| apiKey string | ||
| connectOptions []connect.ClientOption | ||
| } | ||
|
|
||
| // ClientOption is an interface for configuring a client. Using such options helpers is a | ||
| // quite common pattern in Go, as it allows for optional parameters in constructors. | ||
| // This concrete implementation here is inspired by how libraries such as axiom-go and connect do their | ||
| // configuration. | ||
| type ClientOption func(*clientConfig) | ||
|
|
||
| func WithHTTPClient(httpClient connect.HTTPClient) ClientOption { | ||
| return func(cfg *clientConfig) { | ||
| cfg.httpClient = httpClient | ||
| } | ||
| } | ||
|
|
||
| func WithURL(url string) ClientOption { | ||
| return func(cfg *clientConfig) { | ||
| cfg.url = url | ||
| } | ||
| } | ||
|
|
||
| func WithAPIKey(apiKey string) ClientOption { | ||
| return func(cfg *clientConfig) { | ||
| cfg.apiKey = apiKey | ||
| } | ||
| } | ||
|
|
||
| func WithConnectClientOptions(options ...connect.ClientOption) ClientOption { | ||
| return func(cfg *clientConfig) { | ||
| cfg.connectOptions = append(cfg.connectOptions, options...) | ||
| } | ||
| } | ||
|
|
||
| func newClientConfig(options []ClientOption) *clientConfig { | ||
| cfg := &clientConfig{ | ||
| url: "https://api.tilebox.com", | ||
| } | ||
| for _, option := range options { | ||
| option(cfg) | ||
| } | ||
|
|
||
| // if no http client is set by the user, we use a default one | ||
| if cfg.httpClient == nil { | ||
| // if the URL looks like an HTTP URL, we use a retrying HTTP client | ||
| if strings.HasPrefix(cfg.url, "https://") || strings.HasPrefix(cfg.url, "http://") { | ||
| cfg.httpClient = grpc.RetryHTTPClient() | ||
| } else { // we connect to a unix socket | ||
| dial := func(context.Context, string, string) (net.Conn, error) { | ||
| return net.Dial("unix", cfg.url) | ||
| } | ||
| transport := &http.Transport{DialContext: dial} | ||
| cfg.httpClient = &http.Client{Transport: transport} | ||
| } | ||
| } | ||
|
|
||
| return cfg | ||
| } | ||
|
|
||
| func NewTaskClient(options ...ClientOption) workflowsv1connect.TaskServiceClient { | ||
| cfg := newClientConfig(options) | ||
|
|
||
| return workflowsv1connect.NewTaskServiceClient( | ||
| cfg.httpClient, | ||
| cfg.url, | ||
| connect.WithClientOptions(cfg.connectOptions...), | ||
| connect.WithInterceptors( | ||
| grpc.NewAddAuthTokenInterceptor(func() string { | ||
| return cfg.apiKey | ||
| })), | ||
| ) | ||
| } | ||
|
|
||
| func NewJobClient(options ...ClientOption) workflowsv1connect.JobServiceClient { | ||
| cfg := newClientConfig(options) | ||
|
|
||
| return workflowsv1connect.NewJobServiceClient( | ||
| cfg.httpClient, | ||
| cfg.url, | ||
| connect.WithClientOptions(cfg.connectOptions...), | ||
| connect.WithInterceptors( | ||
| grpc.NewAddAuthTokenInterceptor(func() string { | ||
| return cfg.apiKey | ||
| })), | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.