Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document stuff in the workflow #527

Merged
merged 1 commit into from
Feb 28, 2025
+11 −0
Merged

chore: document stuff in the workflow #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ concurrency:
cancel-in-progress: true

jobs:
# see https://datachain.ai/blog/testing-external-contributions-using-github-actions-secrets
# the point of this is to forbid external contributors from running ci without explicit
# approval from the maintainers (via the environment external-contributors)
# this allows tests to be run with secrets on forks after the maintainers have approved the run
#
# note: you may think the "run ci with approval setting" in github is enough,
# but it doesn't work for pull_request_target
authorize:
environment:
${{ github.event_name == 'pull_request_target' &&
Expand All @@ -38,6 +45,8 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
# in a pull_request_target event, the ref is the `main` branch not the PR branch
# so we need to tell checkout to use the head.ref instead.
ref: ${{ github.event.pull_request.head.ref || github.ref }}

- uses: taiki-e/install-action@just
Expand Down Expand Up @@ -121,6 +130,8 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
# in a pull_request_target event, the ref is the `main` branch not the PR branch
# so we need to tell checkout to use the head.ref instead.
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- uses: taiki-e/install-action@just
Expand Down