v0.5.10: Implemented more tests, improved Pairi Daiza, added Efteling…

… menus
timyboy12345 · Nov 27, 2024 · bd3c219 · bd3c219
1 parent 6d72410
commit bd3c219
Show file tree

Hide file tree

Showing 18 changed files with 202 additions and 106 deletions.
diff --git a/README.md b/README.md
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "themeparks-node-api",
-  "version": "0.5.9",
+  "version": "0.5.10",
   "description": "An API which can retrieve theme park wait times.",
   "author": "Tim Arendsen",
   "private": false,

diff --git a/src/parks/beekse-bergen/beekse-bergen-transfer/beekse-bergen-transfer.service.ts b/src/parks/beekse-bergen/beekse-bergen-transfer/beekse-bergen-transfer.service.ts
@@ -19,6 +19,7 @@ export class BeekseBergenTransferService extends TransferService {
     return this.transferItemToPoi(PoiCategory.ATTRACTION, ride);
   }
 
+  // TODO: Implement new API url
   private transferItemToPoi(category: PoiCategory, data: BeekseBergenApiResponseItem): Poi {
     const poi: Poi = {
       category: category,

diff --git a/src/parks/beekse-bergen/safaripark/safaripark.service.ts b/src/parks/beekse-bergen/safaripark/safaripark.service.ts
@@ -70,6 +70,7 @@ export class SafariparkService extends ThroughPoisThemeParkService {
     return this.transferService.transferDataObjectToPois(d);
   }
 
+  // TODO: Use other API endpoint to fetch more data
   async fetchPage(page: number): Promise<BeekseBergenLocationsResponseInterface> {
     // Beekse Bergen Resort ID: 5, Speelland: 6
     const url = 'https://xmp.xo10.io/api/locations?populate=*&filters%5Bresort%5D=5';

diff --git a/src/parks/efteling/efteling-transfer/efteling-transfer.service.ts b/src/parks/efteling/efteling-transfer/efteling-transfer.service.ts
@@ -94,6 +94,10 @@ export class EftelingTransferService extends TransferService {
       };
     }
 
+    if (eftelingPoi.fields.menu_card_pdf) {
+      poi.menuUrl = eftelingPoi.fields.menu_card_pdf;
+    }
+
     if (c === PoiCategory.ATTRACTION) {
       if (eftelingPoi.fields.targetgroups) {
         if (eftelingPoi.fields.targetgroups.includes('whole-family')) {
@@ -176,9 +180,9 @@ export class EftelingTransferService extends TransferService {
             openTime: ot.Open,
             close: ot.Close,
             closeTime: ot.Close,
-          }
-        })
-      }
-    })
+          };
+        }),
+      };
+    });
   }
 }
diff --git a/src/parks/efteling/interfaces/efteling-poi.interface.ts b/src/parks/efteling/interfaces/efteling-poi.interface.ts
@@ -10,6 +10,7 @@ export interface EftelingPoi {
     text: string,
     can_order: boolean,
     latlon: string,
+    menu_card_pdf: string | null,
     targetgroups: string[],
     language: string,
 

diff --git a/src/parks/familypark/familypark/familypark.service.spec.ts b/src/parks/familypark/familypark/familypark.service.spec.ts
@@ -15,4 +15,14 @@ describe('FamilyparkService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
+
+  // it('should return info', () => {
+  //   expect(service.getInfo().id).toBeDefined();
+  // });
+  //
+  // it('should return a list of POIs', async () => {
+  //   const data = await service.getPois();
+  //   expect(data).toBeInstanceOf(Array);
+  //   expect(data.length).toBeGreaterThan(6);
+  // }, 1000 * 60);
 });
diff --git a/src/parks/familypark/familypark/familypark.service.ts b/src/parks/familypark/familypark/familypark.service.ts
@@ -2,3 +2,4 @@ import { Injectable } from '@nestjs/common';
 
 @Injectable()
 export class FamilyparkService {}
+// TODO: Implement Family Park
diff --git a/src/parks/merlin-entertainments/heidi-park/heidi-park.service.spec.ts b/src/parks/merlin-entertainments/heidi-park/heidi-park.service.spec.ts
@@ -19,4 +19,14 @@ describe('HeidiParkService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
+
+  it('should return info', () => {
+    expect(service.getInfo().id).toBeDefined();
+  });
+
+  it('should return a list of POIs', async () => {
+    const data = await service.getPois();
+    expect(data).toBeInstanceOf(Array);
+    expect(data.length).toBeGreaterThan(6);
+  }, 1000 * 60);
 });
diff --git a/src/parks/pairi-daiza/pairi-daiza-transfer/pairi-daiza-transfer.service.ts b/src/parks/pairi-daiza/pairi-daiza-transfer/pairi-daiza-transfer.service.ts
@@ -8,6 +8,7 @@ import {
 } from '../interfaces/PairiDaizaResponse';
 import { PoiCategory } from '../../../_interfaces/poi-categories.enum';
 import * as moment from 'moment-timezone';
+import * as sluggo from 'sluggo';
 
 @Injectable()
 export class PairiDaizaTransferService extends TransferService {
@@ -42,8 +43,9 @@ export class PairiDaizaTransferService extends TransferService {
         break;
     }
 
-    p.title = poi.Name[loc];
+    p.title = this.titleCase(poi.Name[loc]);
     p.description = poi.Description[loc];
+    p.id = sluggo(poi.Name[loc])
 
     p.facts = [];
     if ('AnimalClass' in poi) {
@@ -116,7 +118,7 @@ export class PairiDaizaTransferService extends TransferService {
             });
           } else {
             p.openingTimes.push({
-              date: moment().format(),
+              date: moment().format('YYYY-MM-DD'),
               open: start.format(),
               openTime: start.format('HH:mm:ss'),
               close: oh.EndHour !== '00:00:00' ? end.format() : undefined,
@@ -157,4 +159,17 @@ export class PairiDaizaTransferService extends TransferService {
       category: PoiCategory.SHOP,
     };
   }
+
+  private titleCase(str: string): string {
+    const splitStr = str.toLowerCase().split(' ');
+
+    for (let i = 0; i < splitStr.length; i++) {
+      // You do not need to check if i is larger than splitStr length, as your for does that for you
+      // Assign it back to the array
+      splitStr[i] = splitStr[i].charAt(0).toUpperCase() + splitStr[i].substring(1);
+    }
+
+    // Directly return the joined string
+    return splitStr.join(' ');
+  }
 }
diff --git a/src/parks/pairi-daiza/pairi-daiza.service.spec.ts b/src/parks/pairi-daiza/pairi-daiza.service.spec.ts
@@ -20,4 +20,14 @@ describe('PairiDaizaService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
+
+  it('should return info', () => {
+    expect(service.getInfo().id).toBeDefined();
+  });
+
+  it('should return a list of POIs', async () => {
+    const data = await service.getPois();
+    expect(data).toBeInstanceOf(Array);
+    expect(data.length).toBeGreaterThan(6);
+  }, 1000 * 60);
 });
diff --git a/src/parks/pairi-daiza/pairi-daiza.service.ts b/src/parks/pairi-daiza/pairi-daiza.service.ts
@@ -22,7 +22,7 @@ export class PairiDaizaService extends ThemeParkService {
         lng: 3.8873162,
       },
       parkType: ParkType.ZOO,
-      countryCode: 'BE',
+      countryCode: 'be',
     };
   }
 
@@ -35,7 +35,7 @@ export class PairiDaizaService extends ThemeParkService {
       supportsPoiLocations: true,
       supportsPois: false,
       supportsRestaurantOpeningTimes: false,
-      supportsRestaurants: false,
+      supportsRestaurants: true,
       supportsRideWaitTimes: false,
       supportsRideWaitTimesHistory: false,
       supportsRides: false,

diff --git a/src/parks/parques-reunidos/bobbejaanland/bobbejaanland.service.spec.ts b/src/parks/parques-reunidos/bobbejaanland/bobbejaanland.service.spec.ts
@@ -19,4 +19,14 @@ describe('BobbejaanlandService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
+
+  it('should return info', () => {
+    expect(service.getInfo().id).toBeDefined();
+  });
+
+  it('should return a list of POIs', async () => {
+    const data = await service.getPois();
+    expect(data).toBeInstanceOf(Array);
+    expect(data.length).toBeGreaterThan(6);
+  }, 1000 * 60);
 });
diff --git a/src/parks/parques-reunidos/marineland-cote-dazur/marineland-cote-dazur.service.spec.ts b/src/parks/parques-reunidos/marineland-cote-dazur/marineland-cote-dazur.service.spec.ts
@@ -19,4 +19,14 @@ describe('MarinelandCoteDazurService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
+
+  it('should return info', () => {
+    expect(service.getInfo().id).toBeDefined();
+  });
+
+  it('should return a list of POIs', async () => {
+    const data = await service.getPois();
+    expect(data).toBeInstanceOf(Array);
+    expect(data.length).toBeGreaterThan(6);
+  }, 1000 * 60);
 });
diff --git a/src/parks/parques-reunidos/mirabilandia/mirabilandia.service.spec.ts b/src/parks/parques-reunidos/mirabilandia/mirabilandia.service.spec.ts
@@ -19,4 +19,14 @@ describe('MirabilandiaService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
+
+  it('should return info', () => {
+    expect(service.getInfo().id).toBeDefined();
+  });
+
+  it('should return a list of POIs', async () => {
+    const data = await service.getPois();
+    expect(data).toBeInstanceOf(Array);
+    expect(data.length).toBeGreaterThan(6);
+  }, 1000 * 60);
 });
diff --git a/src/parks/san-diego-zoo/san-diego-safari-park/san-diego-safari-park.service.spec.ts b/src/parks/san-diego-zoo/san-diego-safari-park/san-diego-safari-park.service.spec.ts
@@ -15,4 +15,14 @@ describe('SanDiegoSafariParkService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
+
+  // it('should return info', () => {
+  //   expect(service.getInfo().id).toBeDefined();
+  // });
+  //
+  // it('should return a list of POIs', async () => {
+  //   const data = await service.getPois();
+  //   expect(data).toBeInstanceOf(Array);
+  //   expect(data.length).toBeGreaterThan(6);
+  // }, 1000 * 60);
 });
diff --git a/src/parks/san-diego-zoo/san-diego-safari-park/san-diego-safari-park.service.ts b/src/parks/san-diego-zoo/san-diego-safari-park/san-diego-safari-park.service.ts
@@ -2,3 +2,4 @@ import { Injectable } from '@nestjs/common';
 
 @Injectable()
 export class SanDiegoSafariParkService {}
+// TODO: Implement Safari Park
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,3 +2,4 @@ import { Injectable } from '@nestjs/common';

		@Injectable()
		export class FamilyparkService {}
		// TODO: Implement Family Park