Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing codecov issue #439

Closed
wants to merge 5 commits into from
Closed

Conversation

jacobweinstock
Copy link
Member

Description

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

The library is not maintained anymore.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This fixes issues with code coverage.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock jacobweinstock added the do-not-merge Signal to Mergify to block merging of the PR. label Apr 29, 2024
Copy link
Contributor

mergify bot commented Apr 29, 2024

⚠️ The sha of the head commit of this PR conflicts with #438. Mergify cannot evaluate rules on this PR. ⚠️

Trying to resolve codecov not completing
successfully. The secrets.CODECOV_TOKEN was
added to the Tinkerbell org and is available
to all repos.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 69%. Comparing base (8585f46) to head (700fc84).
Report is 4 commits behind head on main.

Files Patch % Lines
cmd/smee/main.go 0% 12 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #439   +/-   ##
===================================
- Coverage    69%    69%   -1%     
===================================
  Files        16     16           
  Lines      1369   1386   +17     
===================================
+ Hits        954    958    +4     
- Misses      389    401   +12     
- Partials     26     27    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Signal to Mergify to block merging of the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant