Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github.com/packethost/xff dependency #451

Merged
merged 5 commits into from
Dec 4, 2024

Run go mod tidy after rebase

c9866a6
Select commit
Loading
Failed to load commit list.
Merged

Remove github.com/packethost/xff dependency #451

Run go mod tidy after rebase
c9866a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 4, 2024 in 0s

56% (+0%) compared to 3dbd175

View this Pull Request on Codecov

56% (+0%) compared to 3dbd175

Details

Codecov Report

Attention: Patch coverage is 70.14925% with 20 lines in your changes missing coverage. Please review.

Project coverage is 56%. Comparing base (3dbd175) to head (c9866a6).

Files with missing lines Patch % Lines
internal/ipxe/http/xff.go 71% 17 Missing and 2 partials ⚠️
internal/ipxe/http/http.go 0% 1 Missing ⚠️
Additional details and impacted files 
@@         Coverage Diff         @@
##           main   #451   +/-   ##
===================================
  Coverage    56%    56%           
===================================
  Files        31     32    +1     
  Lines      3555   3621   +66     
===================================
+ Hits       1994   2050   +56     
- Misses     1487   1497   +10     
  Partials     74     74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov