Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how we check for OSIE.BaseURL: #593

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jacobweinstock
Copy link
Member

Description

The object that gets returned from Kubernetes seems to always come back non-nil. So we need to also check if the string is empty.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

The object that gets returned from Kubernetes
seems to always come back non-nil. So we need
to also check if the string is empty.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock jacobweinstock added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56%. Comparing base (592aa2c) to head (ad251cd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/ipxe/script/ipxe.go 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #593   +/-   ##
===================================
  Coverage    56%    56%           
===================================
  Files        32     32           
  Lines      3624   3624           
===================================
  Hits       2056   2056           
  Misses     1495   1495           
  Partials     73     73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobweinstock jacobweinstock merged commit c0443b8 into tinkerbell:main Jan 30, 2025
4 of 5 checks passed
@jacobweinstock jacobweinstock deleted the osie-baseurl-bugfix branch January 30, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant