Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct date params #89

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Use correct date params #89

merged 1 commit into from
Sep 24, 2024

Conversation

rmorehig
Copy link
Contributor

Description

We were using the wrong params start_date and end_date instead of date_from and date_to

Fixes #86

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have update the CHANGELOG
  • New and existing unit tests pass locally with my changes

@rmorehig rmorehig requested a review from sdairs as a code owner September 24, 2024 15:27
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 3:27pm

@alejandromav alejandromav self-requested a review September 24, 2024 15:28
@rmorehig rmorehig merged commit 5d81159 into main Sep 24, 2024
4 checks passed
@rmorehig rmorehig deleted the fix-dates-charts branch September 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Table and Plots Fail to Sync After Time Period Change
2 participants