Dashboards: Remove default empty string from variable create view (gr…

…afana#98922) * default empty string * optimize
tipee-sa · Feb 3, 2025 · 6496705 · 6496705
1 parent e015152
commit 6496705
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/e2e/dashboards-suite/new-query-variable.spec.ts b/e2e/dashboards-suite/new-query-variable.spec.ts
@@ -72,7 +72,7 @@ describe('Variables - Query - Add variable', () => {
       cy.get('input[type="checkbox"]').should('not.be.checked');
     });
 
-    e2e.pages.Dashboard.Settings.Variables.Edit.General.previewOfValuesOption().should('not.have.text');
+    e2e.pages.Dashboard.Settings.Variables.Edit.General.previewOfValuesOption().should('not.exist');
     e2e.pages.Dashboard.Settings.Variables.Edit.General.selectionOptionsCustomAllInput().should('not.exist');
   });
 

diff --git a/public/app/features/dashboard-scene/settings/variables/VariableEditorForm.tsx b/public/app/features/dashboard-scene/settings/variables/VariableEditorForm.tsx
@@ -113,7 +113,7 @@ export function VariableEditorForm({
 
       {EditorToRender && <EditorToRender variable={variable} onRunQuery={onRunQuery} />}
 
-      {isHasVariableOptions && <VariableValuesPreview options={variable.getOptionsForSelect()} />}
+      {isHasVariableOptions && <VariableValuesPreview options={variable.getOptionsForSelect(false)} />}
 
       <div className={styles.buttonContainer}>
         <Stack gap={2}>