-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement signMessage on Solana TurnkeySigner #202
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ed1fca1
to
0ddd1cb
Compare
"Hello world", | ||
turnkeySolAddress | ||
); | ||
expect(signature).toBeDefined(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great to be able to verify the signature on the spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for making this PR 🙏
one tiny thing to call out is that some signMessages
implementations (e.g. on solana web3) are expected to return bytes/Uint8Array
I can return a byte array instead of string to be more generic? |
Yup! That'd be perfect. Also, if we make this change, then I believe the |
cbe7b90
to
e478380
Compare
f74ff66
to
cbbfc96
Compare
cbbfc96
to
3232aae
Compare
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset
.pnpm changeset
will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.