Session Management #486
Session Management #486
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2b8c960:
|
| ### @turnkey/sdk-react | ||
|
|
||
| - update `TurnkeyContext` to use new `.getSession()` method to check if there is an active session | ||
| - `OTPVerification` component no longer receives `authIframeClient` or `onValidateSuccess` props |
There was a problem hiding this comment.
optional: mind sharing what the rationale is/how we now achieve the same effect?
There was a problem hiding this comment.
I'm obtaining a reference to the authIframeClient directly in the OTPVerification component via the useTurnkey() hook.
Depending on the use case, I am handling the equivalent of onValidateSuccess in Auth.tsx or directly within OTPVerification itself.
| type Session = { | ||
| sessionType: string; | ||
| sessionType: SessionType; |
There was a problem hiding this comment.
same comment as a similar spot in sdk-browser — documenting these types could be useful, if not too inconvenient
There was a problem hiding this comment.
@andrewkmin they should be able to refer to the enum above?
There was a problem hiding this comment.
Yup!! That makes sense
Co-authored-by: am <andrew@turnkey.io>
turnekybc
force-pushed
the
moe/session-management
branch
from
fe943e3 to
98b7a9d
Compare
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.