Update user auth abstraction #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
moeodeh3
reviewed
Feb 24, 2025
| deleteIds?: string[]; // Authenticator IDs to delete | ||
| }; | ||
| oauthProviders?: { | ||
| add?: any[]; // OAuth provider objects to create |
There was a problem hiding this comment.
any reason why these are of type any?
turnekybc
reviewed
Feb 24, 2025
| } | ||
|
|
||
| // Execute all additions in parallel | ||
| return Promise.all(promises); |
There was a problem hiding this comment.
Are we surfacing any errors to the user in the situation where one or more of the promises are not successful?
turnekybc
reviewed
Feb 24, 2025
| deleteIds?: string[]; // OAuth provider IDs to delete | ||
| }; | ||
| apiKeys?: { | ||
| add?: any[]; // API key objects to create |
There was a problem hiding this comment.
Same comment here as @moeodeh3 above, are we able to type this?
There was a problem hiding this comment.
Was thinking w.r.t code maintenance purposes since we can't reference the type directly afaik
moe-dev
force-pushed
the
moe/update-auth
branch
from
c9d4103 to
e8eed30
Compare
turnekybc
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.