RN multiple sessions #520

moeodeh3 · 2025-02-28T13:52:27Z

Summary & Motivation

This PR adds support for multiple sessions by allowing sessions to be created with a custom sessionKey instead of using a single default session. We also introduced the concept of a "selected session," meaning users can switch between sessions by calling setSelectedSession( {sessionKey: <key here>}) , which updates the client, user, and session info accordingly. Any function calls, like updateUser or createWallet, now apply to the selected session.

How I Tested These Changes

tested in a custom app using the expo-template :)

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

codesandbox-ci · 2025-02-28T13:54:13Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

…th expo

packages/sdk-react-native/src/constants.ts

zkharit

Couple comments, HUGE improvement adding multiple sessions!!

zkharit · 2025-03-04T22:06:59Z

packages/sdk-react-native/package.json

+  },
+  "peerDependencies": {
+    "@types/react": "^18.2.75",
+    "react": "^16.8.0 || ^17.0.0 || ^18.0.0",


This is a wide range of versions for some of these dependencies, can be bit more explicit about which versions will be used, or is there some reason this range is needed?

I just did this to follow what we do in sdk-react. I believe because we only use react for hooks, any version above 16.8.0 is sufficient. But we don't want users to think we restrict other major releases so thats why we do this. I could be wrong though - maybe @moe-dev could comment on this. If this is unnecessary I can update both sdk-react and sdk-react-native

packages/sdk-react-native/package.json

packages/sdk-react-native/src/types.ts

zkharit · 2025-03-04T23:45:35Z

packages/sdk-react-native/src/storage.ts

@@ -0,0 +1,275 @@
+import * as Keychain from "react-native-keychain";
+import {
+  TURNKEY_EMBEDDED_KEY_STORAGE,


If I understand the flow correctly, we store a long lived api key at TURNKEY_EMBEDDED_KEY_STORAGE in the Keychain, store session keys in the Keychain in their respective "key" as well as in the key index and then store the selected session in the Keychain as well? It feels like the session index may be redundant and could introduce issues with synchronization? But maybe is there a specific reason we need the index that im missing?

the flow looks something like:

createEmbeddedKey() - this generates an api key-pair and stores the private key in local storage under TURNKEY_EMBEDDED_KEY_STORAGE, and returns the public key

user uses the public key (targetPublicKey) to make a request to turnkey

you call createSession() with the credential bundle - this will pull the private key from TURNKEY_EMBEDDED_KEY_STORAGE (also deletes it), decrypt the bundle using the private key, and then saves the session under TURNKEY_DEFAULT_SESSION_STORAGE

so why do we currently store the selected session (TURNKEY_SELECTED_SESSION) and the session index (TURNKEY_SESSION_IDS_INDEX)?

for the useEffect (which runs on app initialization), basically if the user refreshes the app we would like to automatically select the session that was previously selected. Then for the reason we have the TURNKEY_SESSION_IDS_INDEX is because we don't know all the ids we store these sessions under (since the user can set it) so we need to know what service names to pull from in secure storage in the useEffect on app initialization.

I do see what you mean though - let me look into possible ways we can clean this up. Maybe there is a way to get all the service names of stuff in secure storage which would then allow us to remove TURNKEY_SESSION_IDS_INDEX.

packages/sdk-react-native/README.md

packages/sdk-react-native/src/storage.ts

andrewkmin · 2025-03-05T14:41:05Z

packages/sdk-react-native/src/storage.ts

+
+/**
+ * Retrieves the stored embedded key from secure storage.
+ * Optionally deletes the key from storage after retrieval.


just to explain this in writing, the key can be deleted from storage after retrieval because ultimately, the full on decrypted API key will be stored in secure storage, correct? in which case the credential bundle/embedded key are no longer needed?

packages/sdk-react-native/src/storage.ts

packages/sdk-react-native/src/turnkey-helpers.ts

packages/sdk-react-native/src/contexts/TurnkeyContext.tsx

andrewkmin · 2025-03-05T18:21:00Z

packages/sdk-react-native/README.md


- `turnkey-embedded-key`: Stores the private key that corresponds to the public key used when initiating the session request to Turnkey.
- `turnkey-session`: Stores the session credentials, including the private key, public key, and expiry time, which are decrypted from the credential bundle after a session is created.
+Using multiple sessions can be beneficial when enabling different authentication methods for various operations. For example, you might authenticate a user with OTP for login while using a passkey-based session for signing transactions.


andrewkmin · 2025-03-05T18:32:27Z

packages/sdk-react-native/src/contexts/TurnkeyContext.tsx

-    });
-    return new TurnkeyClient({ baseUrl: apiBaseUrl }, stamper);
-  };
+          config.onSessionSelected?.(selectedSession!);


andrewkmin · 2025-03-05T18:36:13Z

packages/sdk-react-native/src/contexts/TurnkeyContext.tsx

+        ...(email?.trim() && { userEmail: email }),
+      };
+
+      const result = await client.updateUser({


realized we're using the raw http Turnkey client here, instead of something akin to @turnkey/sdk-server which abstracts away the need to specify type/timestamp/org ID. this is def fine for now, but down the line I wonder if it'd help if we had our React Native SDK also have some similar abstractions

andrewkmin · 2025-03-05T18:40:11Z

packages/sdk-react-native/src/contexts/TurnkeyContext.tsx

+
+      await clearSelectedSessionKey();
+
+      setSession(undefined);


using undefined here is helpful — there could also be an argument made for just calling setSession(), without any arguments, but I think this works great too

setSession() is a state function - I don't think we can do that unless we write a helper function and call it inside. I think I would prefer setSession(undefined) but if you disagree I can change it

andrewkmin · 2025-03-05T18:53:01Z

packages/sdk-react-native/src/storage.ts

+
+    if (credentials) {
+      try {
+        keys = JSON.parse(credentials.password);


probably overkill, but wouldn't be too bad to include a description on how Keychain.getGenericPassword() works. i.e. that we're really actually storing the sensitive data (session keys) under credentials.password , and that credentials.password doesn't actually have to be a literal password

added concept of storageKeys to handle multiple sessions

4d40529

moeodeh3 changed the title ~~RN multiple sessions~~ RN multiple sessions [wip] Feb 28, 2025

moeodeh3 added 5 commits February 28, 2025 13:44

sessions refactor

c33d7a3

downgraded version of @react-native-async-storage to be compatible wi…

15b7074

…th expo

fix build errors

146412b

pnpm i

6fb8105

cleaned up dependencies

6bf5ed0

moeodeh3 force-pushed the moeO/multipleSessions branch from c1fc276 to 6bf5ed0 Compare March 2, 2025 00:39

moeodeh3 added 7 commits March 1, 2025 21:43

moved away from async storage to keychain storage

8725c15

fixed consistency issues, and small bugs found

0af1790

removed optional scheduleExpiry, more fixes

4cc9e42

fixed ussue with scheduleSessionExpiration

b051c84

fixed input for createSession

77cf587

wrapped functions in useCallbacks, and wrapped provider in useMemo

ac65851

cleaned up, added comment headers

2c3e470

andrewkmin reviewed Mar 4, 2025

View reviewed changes

packages/sdk-react-native/src/constants.ts Outdated Show resolved Hide resolved

moeodeh3 added 2 commits March 4, 2025 17:42

small fixes, updated readme

04087e8

resolved comment

6d7712e

zkharit reviewed Mar 4, 2025

View reviewed changes

moeodeh3 added 2 commits March 5, 2025 00:27

resolved more comments

752fdc6

prettier

d5edd8b

andrewkmin reviewed Mar 5, 2025

View reviewed changes

resolved more comments

833ebbb

andrewkmin reviewed Mar 5, 2025

View reviewed changes

added clearAllSessions() and fixed small bug

7d7d2f1

andrewkmin approved these changes Mar 5, 2025

View reviewed changes

moeodeh3 added 2 commits March 5, 2025 14:11

fixed, prettier

50d9454

added changeset

fcf9503

moe-dev approved these changes Mar 5, 2025

View reviewed changes

moeodeh3 merged commit 7a7e66e into main Mar 5, 2025
5 checks passed

moeodeh3 deleted the moeO/multipleSessions branch March 5, 2025 19:41

moeodeh3 changed the title ~~RN multiple sessions [wip]~~ RN multiple sessions Mar 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RN multiple sessions #520

RN multiple sessions #520

moeodeh3 commented Feb 28, 2025 •

edited

Loading

codesandbox-ci bot commented Feb 28, 2025 •

edited

Loading

zkharit left a comment

zkharit Mar 4, 2025

moeodeh3 Mar 5, 2025

zkharit Mar 4, 2025

moeodeh3 Mar 5, 2025

andrewkmin Mar 5, 2025

moeodeh3 Mar 5, 2025

andrewkmin Mar 5, 2025

andrewkmin Mar 5, 2025

andrewkmin Mar 5, 2025

moeodeh3 Mar 5, 2025

andrewkmin Mar 5, 2025

moeodeh3 Mar 5, 2025

andrewkmin Mar 5, 2025

moeodeh3 Mar 5, 2025

RN multiple sessions #520

RN multiple sessions #520

Conversation

moeodeh3 commented Feb 28, 2025 • edited Loading

Summary & Motivation

How I Tested These Changes

Did you add a changeset?

codesandbox-ci bot commented Feb 28, 2025 • edited Loading

zkharit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moeodeh3 commented Feb 28, 2025 •

edited

Loading

codesandbox-ci bot commented Feb 28, 2025 •

edited

Loading