Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Model download and FastAPI response #4

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Fix Model download and FastAPI response #4

merged 6 commits into from
Oct 16, 2024

Conversation

ranjan-stha
Copy link
Collaborator

Changes

  • Fixed the model scan and download if necessary
  • Updated the FastAPI response for root path

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)

@ranjan-stha ranjan-stha requested a review from sudan45 October 15, 2024 16:03
@sudan45 sudan45 merged commit 6c6d36a into develop Oct 16, 2024
2 checks passed
@sudan45 sudan45 deleted the fix/model-download branch October 16, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudan45 sudan45 sudan45 approved these changes

Assignees

@sudan45 sudan45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranjan-stha @sudan45