route.md: Add wildcard example code #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
reviewed
Feb 11, 2024
Enselic
force-pushed
the
wildcard-docs
branch
from
587a71e to
a01082a
Compare
To developers completely new to axum, it helps a lot to give example code on to get access to the variable path in a handler. Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
Enselic
force-pushed
the
wildcard-docs
branch
from
a01082a to
3583e6d
Compare
|
Thanks for the review. I think I fixed your comment now. |
|
I'd like to keep my PR outbox clean, so let's close this for now. Doesn't seem worth the effort to keep working on. |
|
Hey, sorry for the long delay. Other than failing CI (which might fix itself with the next run, let's see), this looks good now! |
jplatte
approved these changes
Apr 30, 2024
jplatte
reviewed
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To developers completely new to axum, it helps a lot to give example code on to get access to the variable path in a handler.
Rendered:
Even if the example is not perfect, my hope is that it will be better than nothing. It certainly would have helped me at least.
But feel free to close this PR if the example is too sloppy.