Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync_wrapper to 1.0.0 from 0.1.1 #2667

Merged
merged 18 commits into from
Mar 23, 2024

Conversation

Hmikihiro
Copy link
Contributor

Motivation

sync_wrapper had a dependency future-core until version 0.1.1.
Now, future-core is optional in sync_wrapper from version 0.1.2
struct SyncStream is dependent future-core but axum doesn't use struct SyncStream.

Updating to version 0.1.2 or later separates sync_wrapper from future-core.

Solution

Update sync_wrapper to 1.0.0

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jplatte
Copy link
Member

jplatte commented Mar 22, 2024

Do you mind updating the MSRV in Cargo.toml to 1.57 for axum-core, to fix CI?

@jplatte
Copy link
Member

jplatte commented Mar 23, 2024

Damn, more errors. If you want you can try to fix them here, otherwise I'll try to find some time for doing that separately soon.

@Hmikihiro
Copy link
Contributor Author

Sorry, I could not fix CI/test-nightly. I fix only CI/check.

@Hmikihiro
Copy link
Contributor Author

I think I have fixed all the Cl/test-nightly.

@jplatte jplatte merged commit c6fd852 into tokio-rs:main Mar 23, 2024
18 checks passed
@jplatte
Copy link
Member

jplatte commented Mar 23, 2024

Wow that was a lot of stuff that created new warnings all at once. Thanks a lot for taking care of all the small changes required to make CI happy again!

@Hmikihiro Hmikihiro deleted the sync-wrapper-to100 branch March 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants