feat: Logo, HeaderTitle components #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Manvinderjit Rupal <manvinderjit@users.noreply.github.com>
Deploying volunteer with
|
| Latest commit: |
b466922
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://250ca09a.volunteer-ekr.pages.dev |
| Branch Preview URL: | https://style-global-css.volunteer-ekr.pages.dev |
manvinderjit
force-pushed
the
feat/header
branch
from
bee0887 to
c751d4c
Compare
Co-authored-by: Evan Suhyeong Lee <devleesche@gmail.com>
manvinderjit
force-pushed
the
feat/header
branch
from
c751d4c to
d9f8dfb
Compare
Co-authored-by: Evan Suhyeong Lee <devleesche@gmail.com>
sounmind
force-pushed
the
feat/header
branch
from
3ea6a11 to
f399728
Compare
madcampos
reviewed
Feb 17, 2025
public/torontojs-logo.png
Outdated
There was a problem hiding this comment.
nitpick: Please use the SVG logo instead: https://github.com/torontojs/tojs-styleguide/blob/main/Old/public/assets/logo.svg
Vector graphics look sharper than raster and are usually smaller. Our logo has relative simple shapes and colors, making it a very good candidate for vector graphics.
Comment on lines
+2
to
+3
| height: 128px; | ||
| width: 128px; |
There was a problem hiding this comment.
praise: Please use relative units instead of absolute ones, they are less responsive!
Here is a video with one specific example: https://www.youtube.com/watch?v=xCSw6bPXZks
sounmind
force-pushed
the
style/global-css
branch
from
b466922 to
38e5b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Additional information