Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize_path: Add Append mode #547

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

normalize_path: Add Append mode #547

wants to merge 2 commits into from

Conversation

daalfox
Copy link

@daalfox daalfox commented Mar 1, 2025

Closes #530

@daalfox
Copy link
Author

daalfox commented Mar 1, 2025

I tried to just solve the #530 in this PR. But I think we can improve this further. Currently merging slashes are happening implicitly which I think should be explicit. I can also refactor this and split the code for different modes.

@daalfox
Copy link
Author

daalfox commented Mar 1, 2025

As for the naming, I added a new function that takes mode but maybe we want to add some convenience functions. I suggest normalize_trim and normalize_append or just trim and append because we know it's an http specific service already. Maybe merge_slashes, merge_trim, merge_append in future?

@daalfox daalfox marked this pull request as ready for review March 2, 2025 09:44
@daalfox
Copy link
Author

daalfox commented Mar 3, 2025

@jplatte Can you check this out? I understand you might be busy, just tagging in case you missed it.

@jplatte
Copy link
Collaborator

jplatte commented Mar 3, 2025

I saw, just busy. Feel free to ping me again in a week or two if I haven't responded then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make normalize_path configurable to allow for trailing slashes
2 participants