fix eof bugs: reject input where only strict prefix is valid

tqtezos · Dec 9, 2019 · 4958948 · 4958948
1 parent 7e6c10b
commit 4958948
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/package.yaml b/package.yaml
@@ -30,6 +30,7 @@ library:
     - binary
     - lorentz-contracts
     - optparse-applicative
+    - megaparsec
 
 executables:
   lorentz-contract:

diff --git a/src/Lorentz/Contracts/GenericMultisig/Wrapper.hs b/src/Lorentz/Contracts/GenericMultisig/Wrapper.hs
@@ -5,6 +5,7 @@ module Lorentz.Contracts.GenericMultisig.Wrapper where
 import Data.Singletons
 import qualified Data.Text.Lazy as L
 import Data.Constraint hiding (trans)
+import Text.Megaparsec (eof)
 
 import Lorentz
 import Lorentz.Contracts.ManagedLedger.Types
@@ -24,6 +25,7 @@ import qualified Michelson.TypeCheck.Types as Ty
 import qualified Michelson.Typed.Instr as Instr
 import Lorentz.Contracts.SomeContractParam
 
+import Control.Applicative
 import Data.Type.Equality
 import Text.Show
 import Data.Typeable
@@ -258,7 +260,7 @@ parseTypeCheckValue ::
 parseTypeCheckValue =
   (>>= either (fail . show) return) $
   runTypeCheckIsolated . flip runReaderT def . typeVerifyValue . expandValue <$>
-  value
+  (value <* eof)
 
 -- | Make `StorageParamsParser` for some `Contract`,
 -- assuming a `BigMap` occurs in the storage type